chore: add Librarian team reviewers for all librarian.yaml changes#16763
chore: add Librarian team reviewers for all librarian.yaml changes#16763parthea merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to include the @googleapis/cloud-sdk-librarian-team as owners for librarian.yaml. Feedback suggests removing the leading slash from the file path to ensure all librarian.yaml files across the repository are covered, rather than just the one at the root.
| /packages/pandas-gbq/ @googleapis/bigquery-team @googleapis/bigquery-dataframe-team | ||
| /packages/sqlalchemy-bigquery/ @googleapis/bigquery-team @googleapis/bigquery-dataframe-team | ||
| /packages/sqlalchemy-spanner/ @googleapis/spanner-team | ||
| /librarian.yaml @googleapis/cloud-sdk-librarian-team |
There was a problem hiding this comment.
The pull request title mentions adding reviewers for all librarian.yaml changes. However, the pattern /librarian.yaml is anchored to the repository root and will only match a file at that specific location. If the intention is to cover all librarian.yaml files across the repository (e.g., within various package directories), the leading slash should be removed.
librarian.yaml @googleapis/cloud-sdk-librarian-team
2 participants
Fixes googleapis/librarian#5450